Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement check to see if custom beam and source surface have same shape #201

Open
arendMoerman opened this issue Dec 4, 2024 · 0 comments
Labels
documentation Improvements or additions to documentation question Further information is requested

Comments

@arendMoerman
Copy link
Collaborator

Currently, PyPO does not raise an exception when a custom beam is assigned to a source surface with a different shape. I think we should implement a check that either

  • raises an exception when an attempt is made to associate a custom beam pattern to a surface with different shape
  • gives a warning and reshapes/resizes the surface to match the shape of custom beam pattern.

I guess the last one is what would be the nicest. However, the first option has the nice effect of really reminding users what went wrong. Something to discuss...

@arendMoerman arendMoerman added documentation Improvements or additions to documentation question Further information is requested labels Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant