Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate -m ending for clustering? #428

Closed
martacki opened this issue Sep 28, 2022 · 2 comments · Fixed by #479
Closed

deprecate -m ending for clustering? #428

martacki opened this issue Sep 28, 2022 · 2 comments · Fixed by #479

Comments

@martacki
Copy link
Member

Describe the feature you'd like to see

With PR #415, the current ending -m in the clustering (e.g. elec_s_45m.nc) seems odd. I'd suggest to remove this option, and either substitute this with the possibility to write renewables into exclude_carriers in the config, or simply remove it without substitution. In the latter, users have to manually input which carriers shouldn't be clustered without the default suggestion of the -m ending. I have the feeling that maintaining this -m option is cumbersome even for developers, and I don't have the impression that it is being used.

What do others think?

@fneum
Copy link
Member

fneum commented Nov 18, 2022

Tentatively agree. One disadvantage would be that you cannot easily sweep the different settings by encoding them in a wildcard, e.g.

elec_s_45
elec_s_45m
elec_s_181
elec_s_181m

in one snakemake call.

@fneum
Copy link
Member

fneum commented Feb 22, 2023

I just looked into this again. I don't think there is a benefit to remove it (it's just 3 lines of code), whereas we loose some functionality as mentioned above.

However, I have made a small adjustment in #479 that aligns it to the exclude_carrier functionality.

@fneum fneum closed this as completed in #479 Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants