Issue 518 - Myopic Implementation #554
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update DAGs for documentation site
…ight if statements in the solve_network function to pull the foresight type from a config file. Foresight type option still needs to be added to the repo_data/config/ files, as it is just manually added into the workflow/config currently to avoid init_pypsa_usa.sh reuse. With precommit fixes.
…l running, gives same results as without myopic since we are not pulling from prior timesteps
…tput matches expectations. output does combine first year with the existing infrastructure (need to fix). added in the time dependent components. added a limited part of c in the c.iterate_components, to just include what was in the previous timestep.
…izon, previously was years equal to the investment horizon
… level checks but is giving reasonable results for myopic output. Key change was creating a deep copy of the c.pnl and adding all rather than just input time variables back in after removal
ktehranchi
reviewed
Feb 27, 2025
workflow/scripts/solve_network.py
Outdated
| status, condition = n.optimize.optimize_transmission_expansion_iteratively( | ||
| **kwargs, | ||
| ) | ||
| for i, planning_horizon in enumerate(n.investment_periods): |
There was a problem hiding this comment.
In the case we are solving a perfect foresight model which has multiple investment_periods, we wouldn't want to enter this for loop, correct?
There was a problem hiding this comment.
made a fix for this, will push
Fix clim, other fix for perf foresight.
RPS update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #518 .
Changes proposed in this Pull Request
Added a myopic approach for foresight. Currently missing a few of the 'opts' to work properly with Myopic and that is still being developed (should be completed soon). The current working opt is REM.
Myopic implementation is essentially a for loop in solve_network.py/solve_network after the optimization, copying the p_nom_opt from that time period and saving it as the p_nom to be used for the next period of optimization, and are made non-extendable. The links and lines minimum is set to the previous time period's optimum. Much of this is a simpler version of the add_brownfield.py in PyPSA-eur, as we do not deal with H2 and pipelines, but that may be necessary down the line.
Checklist
envs/environment.yaml.config.default.yaml.doc/configtables/*.csv.