Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the rest of pl_bolts.models.self_supervised #481

Merged

Conversation

akihironitta
Copy link
Contributor

What does this PR do?

Follow-up of #338 #477 #479.

  • Use pragma: no cover instead of pragma: no-cover. (see also: [coverage] Use no cover instead of no-cover #476)
  • Place pragma: no cover at the beginning of clauses.
  • Add missing __all__ to __init__.py files.
  • Use if/else instead of try/except for optional import statements.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Dec 25, 2020

Codecov Report

Merging #481 (78ab7d9) into master (a72766c) will decrease coverage by 0.95%.
The diff coverage is 65.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #481      +/-   ##
==========================================
- Coverage   80.52%   79.57%   -0.96%     
==========================================
  Files         103      103              
  Lines        5710     5830     +120     
==========================================
+ Hits         4598     4639      +41     
- Misses       1112     1191      +79     
Flag Coverage Δ
cpu 24.99% <30.23%> (-0.37%) ⬇️
pytest 24.99% <30.23%> (-0.37%) ⬇️
unittests 79.05% <51.16%> (-1.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pl_bolts/models/self_supervised/cpc/transforms.py 93.40% <53.84%> (-6.60%) ⬇️
pl_bolts/models/self_supervised/moco/transforms.py 90.41% <56.25%> (-9.59%) ⬇️
..._bolts/models/self_supervised/simclr/transforms.py 78.26% <71.42%> (-2.05%) ⬇️
pl_bolts/models/self_supervised/__init__.py 100.00% <100.00%> (ø)
pl_bolts/models/self_supervised/cpc/__init__.py 100.00% <100.00%> (ø)
.../models/self_supervised/simclr/simclr_finetuner.py 13.55% <100.00%> (-86.45%) ⬇️
pl_bolts/models/self_supervised/swav/__init__.py 100.00% <100.00%> (ø)
...olts/models/self_supervised/swav/swav_finetuner.py 15.68% <100.00%> (-84.32%) ⬇️
pl_bolts/models/self_supervised/swav/transforms.py 63.63% <100.00%> (+0.96%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a72766c...78ab7d9. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants