Information Retrieval (6/5) #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Fixed typo in doc format
lucadiliello
requested review from
ananyahjha93,
Borda,
edenlightning,
justusschock,
SkafteNicki and
tchaton
as code owners
Codecov Report
@@ Coverage Diff @@
## master #161 +/- ##
===========================================
- Coverage 96.81% 79.22% -17.60%
===========================================
Files 160 82 -78
Lines 4900 2493 -2407
===========================================
- Hits 4744 1975 -2769
- Misses 156 518 +362
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Borda
approved these changes
Apr 6, 2021
|
@lucadiliello mind adding an entry to changelog... 🐰 |
SkafteNicki
reviewed
Apr 6, 2021
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
auto-merge was automatically disabled
April 6, 2021 17:15
Head branch was pushed to by a user without write access
auto-merge was automatically disabled
April 6, 2021 17:15
Head branch was pushed to by a user without write access
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
SkafteNicki
approved these changes
Apr 6, 2021
auto-merge was automatically disabled
April 6, 2021 17:22
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
implements Fall Our rate for IR. Original discussione here.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃