Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated from v0.4 & fix past #379

Merged
merged 18 commits into from
Jul 24, 2021
Merged

remove deprecated from v0.4 & fix past #379

merged 18 commits into from
Jul 24, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Jul 16, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #371

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the refactoring refactoring and code health label Jul 16, 2021
@Borda Borda changed the title remove deprecated from v0.4 remove deprecated from v0.4 & fix past Jul 16, 2021
@Borda Borda changed the title remove deprecated from v0.4 & fix past [blocked by #382] remove deprecated from v0.4 & fix past Jul 16, 2021
@Borda Borda marked this pull request as draft July 16, 2021 15:39
@Borda Borda changed the title [blocked by #382] remove deprecated from v0.4 & fix past remove deprecated from v0.4 & fix past Jul 16, 2021
@Borda Borda marked this pull request as ready for review July 16, 2021 19:37
@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #379 (e12c0c8) into master (849a200) will decrease coverage by 0.08%.
The diff coverage is 94.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #379      +/-   ##
==========================================
- Coverage   96.45%   96.36%   -0.09%     
==========================================
  Files         117      118       +1     
  Lines        3720     3719       -1     
==========================================
- Hits         3588     3584       -4     
- Misses        132      135       +3     
Flag Coverage Δ
Linux 76.68% <92.00%> (-0.07%) ⬇️
Windows 76.68% <92.00%> (-0.07%) ⬇️
cpu 96.31% <94.00%> (-0.09%) ⬇️
gpu 96.28% <94.00%> (-0.09%) ⬇️
macOS 96.31% <94.00%> (-0.09%) ⬇️
pytest 96.36% <94.00%> (-0.09%) ⬇️
python3.6 95.48% <94.00%> (-0.09%) ⬇️
python3.8 95.56% <94.00%> (-0.84%) ⬇️
python3.9 96.20% <94.00%> (-0.09%) ⬇️
torch1.3.1 95.48% <94.00%> (-0.09%) ⬇️
torch1.4.0 95.56% <94.00%> (-0.09%) ⬇️
torch1.9.0 96.20% <94.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...hmetrics/classification/binned_precision_recall.py 98.63% <ø> (-1.37%) ⬇️
torchmetrics/functional/regression/r2.py 95.12% <ø> (-0.44%) ⬇️
torchmetrics/regression/r2score.py 71.42% <75.00%> (-22.86%) ⬇️
torchmetrics/regression/r2.py 94.28% <94.28%> (ø)
torchmetrics/functional/__init__.py 100.00% <100.00%> (ø)
torchmetrics/functional/regression/__init__.py 100.00% <100.00%> (ø)
torchmetrics/functional/regression/r2score.py 100.00% <100.00%> (ø)
torchmetrics/regression/__init__.py 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 849a200...e12c0c8. Read the comment docs.

@Borda Borda enabled auto-merge (squash) July 22, 2021 15:45
@Borda Borda merged commit c97ac9d into master Jul 24, 2021
@Borda Borda deleted the deprecate/v0.4 branch July 24, 2021 18:53
@Borda Borda added this to the v0.5 milestone Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready refactoring refactoring and code health
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants