Change semantic ordering of kernel_size parameter in SSIM #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
requested review from
ananyahjha93,
Borda,
ethanwharris,
justusschock,
SeanNaren and
tchaton
as code owners
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #474 +/- ##
======================================
- Coverage 96% 75% -21%
======================================
Files 130 130
Lines 4301 4301
======================================
- Hits 4125 3232 -893
- Misses 176 1069 +893 |
Borda
approved these changes
Aug 24, 2021
|
@justusschock mind have look? |
justusschock
approved these changes
Aug 25, 2021
Borda
pushed a commit
that referenced
this pull request
Aug 27, 2021
* implem * changelog Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 94a158c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes #414
Changes the semantic ordering of
kernel_sizeparameter of SSIM metric such that it matches the standard [N, C, H, W] image format. Note this does not change anything for the end user, essentially just a change of variable naming to match standard.Also adds a bit more testing for the metric.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃