Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes mismatch between docstring and code regarding when on_load_checkpoint hook is called #3996

Merged
merged 1 commit into from
Oct 9, 2020

Conversation

hbredin
Copy link
Contributor

@hbredin hbredin commented Oct 8, 2020

What does this PR do?

Fixes #3993

@mergify mergify bot requested a review from a team October 8, 2020 15:53
@Borda Borda changed the title Fixes #3993 Fixes mismatch between docstring and code regarding when on_load_checkpoint hook is called Oct 8, 2020
@mergify mergify bot requested a review from a team October 8, 2020 17:11
@mergify mergify bot requested a review from a team October 8, 2020 17:28
@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #3996 into master will decrease coverage by 2%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #3996    +/-   ##
=======================================
- Coverage      89%     87%    -2%     
=======================================
  Files         212     212            
  Lines       15562   15562            
=======================================
- Hits        13854   13587   -267     
- Misses       1708    1975   +267     

@williamFalcon williamFalcon merged commit a8573b0 into Lightning-AI:master Oct 9, 2020
@Borda Borda added the bug Something isn't working label Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mismatch between docstring and code regarding when on_load_checkpoint hook is called
6 participants