Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore signals on teardown #10611

Merged
merged 33 commits into from
Nov 30, 2021
Merged

Restore signals on teardown #10611

merged 33 commits into from
Nov 30, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Nov 18, 2021

What does this PR do?

Restore the default signal handlers on teardown if Lightning configured their own.

Currently, the Trainer / SignalConnector configures signals when running on SLURM or when fault-tolerant training is enabled. These signals are configured in global namespace, and therefore remain intact after Trainer exits. This may not be a problem normally, but one could run into hard to debug issues when running PL in unit tests. This PR makes sure the signals are properly restored.

Found while working on #10601

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)

cc @Borda @awaelchli @carmocca @justusschock @ninginthecloud @kaushikb11

@awaelchli awaelchli force-pushed the feature/signal-restore branch from 7d22b2b to a9ee439 Compare November 18, 2021 16:08
@awaelchli awaelchli added this to the 1.5.x milestone Nov 18, 2021
@awaelchli awaelchli added the bug Something isn't working label Nov 18, 2021
@awaelchli awaelchli marked this pull request as ready for review November 25, 2021 05:31
@mergify mergify bot removed the has conflicts label Nov 26, 2021
@awaelchli awaelchli force-pushed the feature/signal-restore branch from 3f6136f to 00fbdc3 Compare November 26, 2021 22:55
@awaelchli awaelchli requested a review from carmocca November 26, 2021 22:56
@carmocca carmocca enabled auto-merge (squash) November 28, 2021 17:35
@mergify mergify bot removed the has conflicts label Nov 28, 2021
@mergify mergify bot removed the has conflicts label Nov 30, 2021
@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #10611 (dc023b1) into master (1437be5) will increase coverage by 48%.
The diff coverage is 100%.

❗ Current head dc023b1 differs from pull request most recent head 3f66a45. Consider uploading reports for the commit 3f66a45 to get more accurate results

@@            Coverage Diff            @@
##           master   #10611     +/-   ##
=========================================
+ Coverage      43%      90%    +48%     
=========================================
  Files         177      177             
  Lines       16522    16595     +73     
=========================================
+ Hits         7035    14986   +7951     
+ Misses       9487     1609   -7878     

@mergify mergify bot removed the has conflicts label Nov 30, 2021
@carmocca carmocca merged commit 25473ac into master Nov 30, 2021
@carmocca carmocca deleted the feature/signal-restore branch November 30, 2021 22:07
awaelchli added a commit that referenced this pull request Dec 1, 2021
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
awaelchli added a commit that referenced this pull request Dec 1, 2021
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
awaelchli added a commit that referenced this pull request Dec 1, 2021
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
lexierule pushed a commit that referenced this pull request Dec 7, 2021
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants