-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore signals on teardown #10611
Merged
Merged
Restore signals on teardown #10611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
force-pushed
the
feature/signal-restore
branch
from
November 18, 2021 16:08
7d22b2b
to
a9ee439
Compare
for more information, see https://pre-commit.ci
…ture/signal-restore
12 tasks
12 tasks
for more information, see https://pre-commit.ci
…ture/signal-restore
awaelchli
requested review from
Borda,
carmocca and
justusschock
as code owners
November 25, 2021 05:31
awaelchli
force-pushed
the
feature/signal-restore
branch
from
November 26, 2021 22:55
3f6136f
to
00fbdc3
Compare
for more information, see https://pre-commit.ci
carmocca
approved these changes
Nov 27, 2021
rohitgr7
approved these changes
Nov 29, 2021
Borda
approved these changes
Nov 30, 2021
Codecov Report
@@ Coverage Diff @@
## master #10611 +/- ##
=========================================
+ Coverage 43% 90% +48%
=========================================
Files 177 177
Lines 16522 16595 +73
=========================================
+ Hits 7035 14986 +7951
+ Misses 9487 1609 -7878 |
awaelchli
added a commit
that referenced
this pull request
Dec 1, 2021
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
awaelchli
added a commit
that referenced
this pull request
Dec 1, 2021
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
awaelchli
added a commit
that referenced
this pull request
Dec 1, 2021
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
lexierule
pushed a commit
that referenced
this pull request
Dec 7, 2021
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
environment: slurm
fault tolerance
ready
PRs ready to be merged
trainer: connector
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Restore the default signal handlers on teardown if Lightning configured their own.
Currently, the Trainer / SignalConnector configures signals when running on SLURM or when fault-tolerant training is enabled. These signals are configured in global namespace, and therefore remain intact after Trainer exits. This may not be a problem normally, but one could run into hard to debug issues when running PL in unit tests. This PR makes sure the signals are properly restored.
Found while working on #10601
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)
cc @Borda @awaelchli @carmocca @justusschock @ninginthecloud @kaushikb11