Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix filteration logic for eval results #10810

Merged
merged 12 commits into from
Dec 3, 2021
Merged

Fix filteration logic for eval results #10810

merged 12 commits into from
Dec 3, 2021

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Nov 29, 2021 •
edited by github-actions bot
Loading

What does this PR do?

Fixes #10540

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @carmocca @edward-io @ananthsub

@rohitgr7 rohitgr7 added bug Something isn't working logging Related to the `LoggerConnector` and `log()` labels Nov 29, 2021
@rohitgr7 rohitgr7 added this to the 1.5.x milestone Nov 29, 2021
@rohitgr7 rohitgr7 self-assigned this Nov 29, 2021
@rohitgr7 rohitgr7 marked this pull request as ready for review November 29, 2021 15:12
@rohitgr7 rohitgr7 requested a review from carmocca November 29, 2021 17:22
tchaton
tchaton approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@rohitgr7 rohitgr7 requested a review from carmocca December 3, 2021 10:27
@mergify mergify bot removed the has conflicts label Dec 3, 2021
@mergify mergify bot added the ready PRs ready to be merged label Dec 3, 2021
@carmocca carmocca enabled auto-merge (squash) December 3, 2021 13:44
@carmocca carmocca merged commit 8ba3b38 into master Dec 3, 2021
@carmocca carmocca deleted the fix/eval_results branch December 3, 2021 14:34
rohitgr7 added a commit that referenced this pull request Dec 3, 2021
@rohitgr7 @carmocca
Fix filtration logic for eval results with multiple dataloaders (#10810)
3e689b5 
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
This was referenced Dec 3, 2021
Merged
Merged
lexierule pushed a commit that referenced this pull request Dec 7, 2021
@rohitgr7 @carmocca @lexierule
Fix filtration logic for eval results with multiple dataloaders (#10810)
e4f9656 
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
@carmocca carmocca mentioned this pull request Dec 17, 2021
Open
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchaton tchaton tchaton approved these changes

@carmocca carmocca carmocca approved these changes

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees

@rohitgr7 rohitgr7

Labels
bug Something isn't working logging Related to the `LoggerConnector` and `log()` ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.5.x
Development

Successfully merging this pull request may close these issues.

trainer.test prints duplicate results when self.log(add_dataloader_idx=False)
4 participants
@rohitgr7 @awaelchli @carmocca @tchaton