Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable batch_size extraction for torchmetric instances #10815

Merged
merged 9 commits into from
Nov 30, 2021

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Nov 29, 2021

What does this PR do?

We don't need to extract batch_size if it's a torchmetric instance. Adds a small performance optimization.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)

cc @Borda @carmocca @edward-io @ananthsub

@rohitgr7 rohitgr7 added logging Related to the `LoggerConnector` and `log()` code quality labels Nov 29, 2021
@rohitgr7 rohitgr7 added this to the 1.5.x milestone Nov 29, 2021
@rohitgr7 rohitgr7 self-assigned this Nov 29, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@rohitgr7 rohitgr7 added the bug Something isn't working label Nov 29, 2021
@mergify mergify bot removed the has conflicts label Nov 30, 2021
@rohitgr7 rohitgr7 requested a review from carmocca November 30, 2021 10:14
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Nov 30, 2021
@rohitgr7 rohitgr7 enabled auto-merge (squash) November 30, 2021 20:31
@rohitgr7 rohitgr7 merged commit 1437be5 into master Nov 30, 2021
@rohitgr7 rohitgr7 deleted the ref/bs_infer_tensor branch November 30, 2021 20:47
rohitgr7 added a commit that referenced this pull request Dec 1, 2021
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
lexierule pushed a commit that referenced this pull request Dec 7, 2021
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working code quality logging Related to the `LoggerConnector` and `log()` ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants