Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve: 'DummyExperiment' object does not support item assignment #10917

Merged
merged 7 commits into from
Dec 3, 2021

Conversation

lucmos
Copy link
Contributor

@lucmos lucmos commented Dec 3, 2021

What does this PR do?

Add the __setitem__ method to the DummyExperiment

The new Neptune API use a dict-like interface to log metrics/parameters, thus the DummyExperiment must have a __setitem__ implemented otherwise an error is raised:

'DummyExperiment' object does not support item assignment

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@justusschock
Copy link
Member

justusschock commented Dec 3, 2021

@lucmos thanks for your PR: do you have a concrete usecase where you encounter this? Ideally with a reproducible minimal example? Ideally we would discuss such things in an issue (we appreciate proposed solutions there very much) before sending a PR and then linking that issue here so that everybody can look up the reason for this change :)

I don't see how this could hurt, but reluctant to approve it without more information :)

Also a test and a changelog entry would be required

@awaelchli awaelchli added bug Something isn't working logger Related to the Loggers labels Dec 3, 2021
@lucmos
Copy link
Contributor Author

lucmos commented Dec 3, 2021

Hello @justusschock, thanks for the quick response! :)
Sure, I skipped the changelog because I considered it an "internal minor change" and the change is quite minimal. I will add the relative test.


The use case is specific to Neptune users who can log with the dict-like syntax:

e.g.

logger.experiment[keyname] = keyvalue

The DummyExperiment is used to dummi-fy the experiment (e.g. in ddp strategies), thus it should support the item assignment in codebases that use the new neptune API.

If you prefer I can make the colab mwe though

tests/loggers/test_base.py Show resolved Hide resolved
lucmos and others added 2 commits December 3, 2021 15:51
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
@mergify mergify bot added the ready PRs ready to be merged label Dec 3, 2021
@justusschock justusschock added this to the 1.5.x milestone Dec 3, 2021
@justusschock justusschock enabled auto-merge (squash) December 3, 2021 16:20
@awaelchli awaelchli self-assigned this Dec 3, 2021
@justusschock justusschock merged commit 7792b77 into Lightning-AI:master Dec 3, 2021
awaelchli added a commit that referenced this pull request Dec 3, 2021
…10917)

Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
lexierule pushed a commit that referenced this pull request Dec 7, 2021
…10917)

Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working logger Related to the Loggers ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants