-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve: 'DummyExperiment' object does not support item assignment #10917
Resolve: 'DummyExperiment' object does not support item assignment #10917
Conversation
@lucmos thanks for your PR: do you have a concrete usecase where you encounter this? Ideally with a reproducible minimal example? Ideally we would discuss such things in an issue (we appreciate proposed solutions there very much) before sending a PR and then linking that issue here so that everybody can look up the reason for this change :) I don't see how this could hurt, but reluctant to approve it without more information :) Also a test and a changelog entry would be required |
Hello @justusschock, thanks for the quick response! :) The use case is specific to Neptune users who can log with the dict-like syntax: e.g. logger.experiment[keyname] = keyvalue The If you prefer I can make the colab mwe though |
for more information, see https://pre-commit.ci
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
for more information, see https://pre-commit.ci
…10917) Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…10917) Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
What does this PR do?
Add the
__setitem__
method to theDummyExperiment
The new Neptune API use a dict-like interface to log metrics/parameters, thus the
DummyExperiment
must have a__setitem__
implemented otherwise an error is raised:Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list: