-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed memory leak from opt return #1528
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Hello @williamFalcon! Thanks for updating this PR.
Comment last updated at 2020-04-19 20:23:02 UTC |
Codecov Report
@@ Coverage Diff @@
## master #1528 +/- ##
======================================
Coverage 91% 91%
======================================
Files 67 68 +1
Lines 3782 3790 +8
======================================
+ Hits 3437 3445 +8
Misses 345 345 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1510
and a few other things along the way.
Now uses .detach to track metrics instead of .item() which keeps speed fast but decreases memory.
Also speeds things up:
Before this PR lightning slowed an epoch by 0.89 seconds, now only by 0.65 seconds (<1 sec per epoch). This baseline is compared with the same model trained using only PyTorch