Don't convert namedtuple to tuple #1589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @nathanbreitsch! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-04-29 01:40:41 UTC |
justusschock
requested changes
Apr 24, 2020
nathanbreitsch
force-pushed
the
bugs/namedtuple-to-gpu
branch
2 times, most recently
from
2efd6b4 to
7ad55ab
Compare
nathanbreitsch
force-pushed
the
bugs/namedtuple-to-gpu
branch
from
7ad55ab to
706517a
Compare
Codecov Report
@@ Coverage Diff @@
## master #1589 +/- ##
======================================
Coverage 88% 88%
======================================
Files 71 71
Lines 4175 4178 +3
======================================
+ Hits 3691 3694 +3
Misses 484 484 |
|
@nathanbreitsch awesome! |
Borda
removed
the
waiting on author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
This is just a proposed solution for sending namedtuples to the GPU without converting them to regular tuples. I am open to suggestions.
Sending data to devices seems to fit the pattern of recursively doing a thing to the elements of contaners. Good examples of this are
default_collateanddefault_convertin pytorch.https://github.com/pytorch/pytorch/blob/master/torch/utils/data/_utils/collate.py#L15
We could take this PR further by following the pattern in pytorch so that lightning works with all the same types. On the other hand, I'm not sure if this pattern satisfies the 'Simple code' requirement.
What does this PR do?
Fixes #1588
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃