Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update type hints for multiple dataloaders in .fit() & .test() #1723

Merged
merged 2 commits into from
May 4, 2020
Merged

Update type hints for multiple dataloaders in .fit() & .test() #1723

merged 2 commits into from
May 4, 2020

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented May 4, 2020

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Multiple dataloaders can be pased to fit and test.
The type hints should reflect that

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team May 4, 2020 00:10
@awaelchli awaelchli added the docs Documentation related label May 4, 2020
@codecov
Copy link

codecov bot commented May 4, 2020

Codecov Report

Merging #1723 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #1723   +/-   ##
======================================
  Coverage      88%     88%           
======================================
  Files          69      69           
  Lines        4131    4131           
======================================
  Hits         3655    3655           
  Misses        476     476           

@Borda
Copy link
Member

Borda commented May 4, 2020

/rebase

@Borda Borda added the ready PRs ready to be merged label May 4, 2020
@mergify mergify bot requested a review from a team May 4, 2020 11:24
@williamFalcon williamFalcon merged commit d28b145 into Lightning-AI:master May 4, 2020
@Borda Borda added this to the 0.7.6 milestone May 4, 2020
@Borda Borda changed the title Update type hints for multiple dataloaders in .fit() and .test() Update type hints for multiple dataloaders in .fit() & .test() May 4, 2020
@awaelchli awaelchli deleted the docs/test_typehint branch May 4, 2020 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants