-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix save_weights_only
flag in ModelCheckpoint
#1780
Fix save_weights_only
flag in ModelCheckpoint
#1780
Conversation
I patched the One alternative would be to read the flag from What's missing is verifying the loading side of things, regarding whether some error handling is necessary. |
0dd2622
to
732c8ce
Compare
save_weights_only
flag in ModelCheckpointsave_weights_only
flag in ModelCheckpoint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the GH diff is strange it makes the same code as change..
This pull request is now in conflict... :( |
`ModelCheckpoint` then passes `self.save_weights_only` to the save function.
…m a weights only checkpoint Also add a test for making sure `ModelCheckpoint.save_weights_only` works as expected.
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
53416fb
to
45b679b
Compare
Codecov Report
@@ Coverage Diff @@
## master #1780 +/- ##
======================================
Coverage 88% 88%
======================================
Files 71 71
Lines 4458 4461 +3
======================================
+ Hits 3915 3918 +3
Misses 543 543 |
@kepler thanks, this is great! |
ModelCheckpoint
then passesself.save_weights_only
to the save function.Before submitting
What does this PR do?
Fixes #427.
PR review
Anyone in the community is free to review the PR once the tests have passed.