Fix test configuration check and testing #1804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @rohitgr7! Thanks for updating this PR.
Comment last updated at 2020-05-13 13:11:07 UTC |
|
This pull request is now in conflict... :( |
|
Working on failed test cases. |
Borda
reviewed
May 13, 2020
| raise MisconfigurationException('You have passed in a `val_dataloader()`' | ||
| ' but have not defined `validation_step()`.') | ||
| if not self.testing: | ||
| if not self.is_overridden('training_step', model): |
There was a problem hiding this comment.
I would consider moving this to __check_model_configuration_test and alternatively bellow
There was a problem hiding this comment.
I suggest removing check_testing_model_configuration because it's just a repeated code and testing configuration can be handled within check_model_configuration. Also during testing check_model_configuration is called which is unnecessary and was not working in #1720. The PR fixes both the issues.
Codecov Report
@@ Coverage Diff @@
## master #1804 +/- ##
======================================
- Coverage 88% 88% -0%
======================================
Files 71 71
Lines 4431 4422 -9
======================================
- Hits 3893 3885 -8
+ Misses 538 537 -1 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes #1720 and #1754.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃