Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable non-blocking for gpu device transfer #1843

Merged
merged 2 commits into from
May 14, 2020
Merged

Enable non-blocking for gpu device transfer #1843

merged 2 commits into from
May 14, 2020

Conversation

justusschock
Copy link
Member

@justusschock justusschock commented May 14, 2020 •
edited
Loading

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Enables non blocking for transfers to gpu

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@justusschock justusschock changed the title Update distrib_parts.py Enable non-blocking for gpu device transfer May 14, 2020
@mergify mergify bot requested a review from a team May 14, 2020 19:46
@Borda Borda added the feature Is an improvement or enhancement label May 14, 2020
@Borda Borda added this to the 0.7.7 milestone May 14, 2020
@mergify mergify bot requested a review from a team May 14, 2020 19:58
@justusschock justusschock marked this pull request as ready for review May 14, 2020 19:58
@williamFalcon williamFalcon merged commit c05077f into master May 14, 2020
@Borda Borda deleted the non_blocking branch May 14, 2020 22:05
@awaelchli awaelchli mentioned this pull request May 14, 2020
Closed
@Borda Borda modified the milestones: 0.7.7, 0.7.6 May 15, 2020
@ZhaofengWu ZhaofengWu mentioned this pull request May 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees
No one assigned
Labels
feature Is an improvement or enhancement
Projects
None yet
Milestone
pl:0.7.x
Development

Successfully merging this pull request may close these issues.
3 participants
@justusschock @Borda @williamFalcon