Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metric docs fix #2209

Merged
merged 34 commits into from
Jun 17, 2020
Merged

Metric docs fix #2209

merged 34 commits into from
Jun 17, 2020

Conversation

SkafteNicki
Copy link
Member

Fix remaining stuff in metrics documentation
@Borda & @williamFalcon

@mergify mergify bot requested a review from a team June 16, 2020 13:57
@Borda Borda added bug Something isn't working docs Documentation related priority: 0 High priority task labels Jun 16, 2020
@Borda Borda added this to the 0.8.0 milestone Jun 16, 2020
Borda
Borda reviewed Jun 16, 2020
View reviewed changes
docs/source/metrics.rst Outdated Show resolved Hide resolved
docs/source/metrics.rst Outdated Show resolved Hide resolved
pytorch_lightning/metrics/classification.py Outdated Show resolved Hide resolved
@mergify mergify bot requested a review from a team June 16, 2020 14:14
@mergify mergify bot requested a review from a team June 16, 2020 14:19
williamFalcon and others added 2 commits June 16, 2020 10:36
@williamFalcon
Update docs/source/metrics.rst
5400081
@williamFalcon @Borda
Update docs/source/metrics.rst
de5083f 
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
@mergify mergify bot requested a review from a team June 16, 2020 14:38
@mergify mergify bot requested a review from a team June 16, 2020 14:40
@williamFalcon
Copy link
Contributor

Nice! @SkafteNicki
If we add the SKlearn metrics we also need examples. Want to copy paste them from the other metrics and modify for sklearn?

@Borda
Copy link
Member

Borda commented Jun 16, 2020

If we add the SKlearn metrics we also need examples. Want to copy paste them from the other metrics and modify for sklearn?

there are already doctests fro sklearn metrics...

@Borda Borda mentioned this pull request Jun 16, 2020
Closed
Nicki Skafte and others added 3 commits June 16, 2020 17:10
@mergify mergify bot requested a review from a team June 16, 2020 15:30
@mergify mergify bot requested a review from a team June 16, 2020 18:09
@Borda
Copy link
Member

Borda commented Jun 16, 2020

@williamFalcon @SkafteNicki @justusschock mind chek the last state...

@Borda Borda self-assigned this Jun 16, 2020
@williamFalcon
Copy link
Contributor 

device = None, dtype = None

    def change_and_check_device_dtype(device, dtype):
>       metric.to(device=device, dtype=dtype)
E       TypeError: to() missing 1 required positional argument: 'self'

Borda
Borda approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did most of the changes so my voice is not relevant this time lol

@mergify mergify bot requested a review from a team June 17, 2020 07:16
@williamFalcon williamFalcon merged commit f1c732a into Lightning-AI:master Jun 17, 2020
@Borda Borda mentioned this pull request Jul 16, 2020
Merged
7 tasks
@SkafteNicki SkafteNicki deleted the metric_docs branch October 8, 2020 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@awaelchli awaelchli Awaiting requested review from awaelchli

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

@jeremyjordan jeremyjordan Awaiting requested review from jeremyjordan

@tullie tullie Awaiting requested review from tullie

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees

@Borda Borda

Labels
bug Something isn't working docs Documentation related priority: 0 High priority task
Projects
None yet
Milestone
pl:0.8
Development

Successfully merging this pull request may close these issues.
6 participants
@SkafteNicki @williamFalcon @Borda @pep8speaks @justusschock @edenlightning