Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the load_from_checkpoint path detected as URL bug #2244

Merged
merged 4 commits into from
Jun 18, 2020
Merged

Fixed the load_from_checkpoint path detected as URL bug #2244

merged 4 commits into from
Jun 18, 2020

Conversation

Molaire
Copy link
Contributor

@Molaire Molaire commented Jun 18, 2020

What does this PR do?

This PR fixes #2243 by both checking if string is a local file and parsing string to see if it's an URL.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team June 18, 2020 20:05
Copy link
Contributor

@yukw777 yukw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Could you also add some tests?

@Molaire
Copy link
Contributor Author

Molaire commented Jun 18, 2020

@yukw777 I'll try my hand at it

@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #2244 into master will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #2244   +/-   ##
======================================
  Coverage      88%     88%           
======================================
  Files          70      70           
  Lines        5435    5436    +1     
======================================
+ Hits         4775    4776    +1     
  Misses        660     660           

@Molaire Molaire removed the request for review from a team June 18, 2020 21:24
@mergify mergify bot requested a review from a team June 18, 2020 21:24
@Borda Borda added the feature Is an improvement or enhancement label Jun 18, 2020
@williamFalcon williamFalcon merged commit 4903f9e into Lightning-AI:master Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model.load_from_checkpoint tries to open file path as URL and fail
4 participants