Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functional regression metrics #2492

Merged
merged 13 commits into from
Jul 9, 2020
Merged

Add functional regression metrics #2492

merged 13 commits into from
Jul 9, 2020

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Jul 3, 2020 •
edited
Loading

What does this PR do?

Add functional regression metrics. Discussed on slack.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented Jul 3, 2020 •
edited
Loading

Hello @rohitgr7! Thanks for updating this PR.

Line 85:1: W293 blank line contains whitespace

Comment last updated at 2020-07-09 15:32:44 UTC

@mergify mergify bot requested a review from a team July 3, 2020 23:05
@rohitgr7
Copy link
Contributor Author

rohitgr7 commented Jul 3, 2020

Please let me know if something needs to be changed. Will write tests once current changes get approved.

@rohitgr7 rohitgr7 changed the title Add functional regression metrics [WIP] Add functional regression metrics Jul 3, 2020
@awaelchli awaelchli mentioned this pull request Jul 3, 2020
Merged
7 tasks
@Borda Borda added the feature Is an improvement or enhancement label Jul 3, 2020
@Borda
Copy link
Member

Borda commented Jul 3, 2020

so far it looks good to me 🐰
cc: @justusschock @SkafteNicki

justusschock
justusschock approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@justusschock justusschock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that they're already tested within PyTorch, but can we still add reference tests to compare to sklearn? Just to be sure, we call everything correctly?

Besides that, it looks good to me :)

@mergify mergify bot requested a review from a team July 6, 2020 06:35
@SkafteNicki
Copy link
Member

Changes until now also looks good to me, remember to update the functional docs with these new functions :)

@rohitgr7
Copy link
Contributor Author

rohitgr7 commented Jul 6, 2020

Yeah, will add tests and make changes to docs tonight✌

@rohitgr7
Copy link
Contributor Author

rohitgr7 commented Jul 6, 2020 •
edited
Loading

Please let me know any other tests needed to be added or any doc updates. Thanks ✌️

@codecov
Copy link

codecov bot commented Jul 6, 2020 •
edited
Loading

Codecov Report

Merging #2492 into master will increase coverage by 1%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #2492    +/-   ##
=======================================
+ Coverage      90%     90%    +1%     
=======================================
  Files          70      70            
  Lines        5689    5902   +213     
=======================================
+ Hits         5097    5340   +243     
+ Misses        592     562    -30

@mergify
Copy link
Contributor

mergify bot commented Jul 8, 2020

This pull request is now in conflict... :(

@SkafteNicki
Copy link
Member

@rohitgr7 PR looks great, if you could solve the merge conflicts (most related to the merge of #2483) I think this is ready to go :)

@Borda Borda added this to the 0.8.x milestone Jul 8, 2020
@rohitgr7 rohitgr7 changed the title [WIP] Add functional regression metrics Add functional regression metrics Jul 8, 2020
@rohitgr7
Copy link
Contributor Author

rohitgr7 commented Jul 8, 2020

@SkafteNicki Done ✌️

SkafteNicki
SkafteNicki approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot requested a review from a team July 9, 2020 07:23
Borda
Borda reviewed Jul 9, 2020
View reviewed changes
pytorch_lightning/metrics/functional/regression.py Outdated Show resolved Hide resolved
pytorch_lightning/metrics/functional/regression.py Outdated Show resolved Hide resolved
pytorch_lightning/metrics/functional/regression.py Outdated Show resolved Hide resolved
pytorch_lightning/metrics/functional/regression.py Outdated Show resolved Hide resolved
pytorch_lightning/metrics/functional/regression.py Outdated Show resolved Hide resolved
tests/metrics/functional/test_regression.py Outdated Show resolved Hide resolved
tests/metrics/functional/test_regression.py Outdated Show resolved Hide resolved
@mergify mergify bot requested a review from a team July 9, 2020 12:50
@Borda Borda merged commit 6f4a488 into Lightning-AI:master Jul 9, 2020
@rohitgr7 rohitgr7 deleted the add_regression_metrics branch July 11, 2020 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@justusschock justusschock justusschock approved these changes

@Borda Borda Borda approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli

Assignees
No one assigned
Labels
feature Is an improvement or enhancement
Projects
None yet
Milestone
pl:0.8.x
Development

Successfully merging this pull request may close these issues.
5 participants
@rohitgr7 @pep8speaks @Borda @SkafteNicki @justusschock