Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gpu idx #2796

Merged
merged 19 commits into from
Aug 2, 2020
Merged

Gpu idx #2796

merged 19 commits into from
Aug 2, 2020

Conversation

williamFalcon
Copy link
Contributor

Fixes gpu indexing broken by: #2739

@mergify mergify bot requested a review from a team August 2, 2020 03:55
@pep8speaks
Copy link

pep8speaks commented Aug 2, 2020

Hello @williamFalcon! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-08-02 11:49:41 UTC

@Borda Borda added the bug Something isn't working label Aug 2, 2020
APEX_AVAILABLE = True


class DDPBackendTemp(object):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the Temp for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a temporary internal refactor

@mergify mergify bot requested a review from a team August 2, 2020 10:09
@codecov
Copy link

codecov bot commented Aug 2, 2020

Codecov Report

Merging #2796 into master will increase coverage by 3%.
The diff coverage is 50%.

@@           Coverage Diff           @@
##           master   #2796    +/-   ##
=======================================
+ Coverage      87%     89%    +3%     
=======================================
  Files          76      78     +2     
  Lines        6825    6997   +172     
=======================================
+ Hits         5909    6252   +343     
+ Misses        916     745   -171     

@williamFalcon williamFalcon merged commit a0c4365 into master Aug 2, 2020
@Borda Borda deleted the gpu_idx branch August 2, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants