Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix apex gradient clipping #2829

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

ruotianluo
Copy link
Contributor

What does this PR do?

Fixes #2556

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team August 4, 2020 22:19
@ruotianluo
Copy link
Contributor Author

Changed the clip_gradients input. not sure if there is any better way.

@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #2829 into master will decrease coverage by 0%.
The diff coverage is 91%.

@@          Coverage Diff           @@
##           master   #2829   +/-   ##
======================================
- Coverage      90%     90%   -0%     
======================================
  Files          78      78           
  Lines        6921    6929    +8     
======================================
+ Hits         6238    6245    +7     
- Misses        683     684    +1     

@williamFalcon williamFalcon merged commit 6034d5e into Lightning-AI:master Aug 5, 2020
@Borda Borda added the bug Something isn't working label Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

apex gradient clipping
3 participants