-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/log computational graph #3003
Feature/log computational graph #3003
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3003 +/- ##
======================================
- Coverage 90% 90% -0%
======================================
Files 81 81
Lines 7626 7694 +68
======================================
+ Hits 6860 6908 +48
- Misses 766 786 +20 |
@SkafteNicki should we disable |
@rohitgr7 I am fine by not logging the graph as default. I just though that automatically adding the graph would be a nice default behavior (if exanple_input_array is defined) for people just using the default logger. But if the warning is annoying we can definitely change this. |
yeah, the warning is a bit annoying. will change to False by default :) |
What does this PR do?
Fixes #2915
Automatically logs the computational graph for certain loggers (tensorboard and test tube, could not find any other loggers that is able to do this). Only requirement is that user has defined the
model.example_input_array
attribute which we already use for model summaries.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃