Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix batch_outputs with optimizer frequencies #3229

Merged
merged 10 commits into from
Sep 10, 2020
Merged

Fix batch_outputs with optimizer frequencies #3229

merged 10 commits into from
Sep 10, 2020

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Aug 27, 2020 •
edited
Loading

What does this PR do?

Fixes #3143

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team August 27, 2020 18:51
@Borda Borda added the bug Something isn't working label Aug 27, 2020
@mergify mergify bot requested a review from a team August 27, 2020 18:58
@rohitgr7
Copy link
Contributor Author

ping @williamFalcon.

@Borda Borda self-requested a review August 27, 2020 19:31
@awaelchli awaelchli linked an issue Aug 27, 2020 that may be closed by this pull request
training multiple optimizers with different frequency #3234
Closed
@awaelchli awaelchli mentioned this pull request Aug 27, 2020
Closed
@rohitgr7 rohitgr7 changed the title [WIP] Fix batch_outputs with optimizers frequencies Fix batch_outputs with optimizers frequencies Aug 28, 2020
@rohitgr7
Copy link
Contributor Author

open to suggestions for tests if required here :)

@rohitgr7 rohitgr7 requested a review from awaelchli August 28, 2020 19:20
@codecov
Copy link

codecov bot commented Aug 28, 2020 •
edited
Loading

Codecov Report

Merging #3229 into master will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #3229   +/-   ##
======================================
  Coverage      90%     90%           
======================================
  Files         100     100           
  Lines        8034    8035    +1     
======================================
+ Hits         7247    7253    +6     
+ Misses        787     782    -5

nisheethlahoti added a commit to rephrase-ai/pytorch-lightning that referenced this pull request Aug 29, 2020
@nisheethlahoti
🐛 Support frequencies for multiple optimizers
da85f45 
see Lightning-AI#3229
@mergify mergify bot requested a review from a team August 29, 2020 13:19
@rohitgr7 rohitgr7 requested a review from awaelchli August 30, 2020 14:36
@rohitgr7 rohitgr7 changed the title Fix batch_outputs with optimizers frequencies Fix batch_outputs with optimizer frequencies Aug 30, 2020
awaelchli
awaelchli approved these changes Aug 30, 2020
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, test fails on master.
this seems an important fix, I would add note to changelog

@mergify mergify bot requested a review from a team August 30, 2020 20:02
@mergify
Copy link
Contributor

mergify bot commented Aug 30, 2020

This pull request is now in conflict... :(

@rohitgr7 rohitgr7 force-pushed the bugfix/opt_freq_batch_update branch from 2b13b40 to e194b9c Compare August 30, 2020 20:26
@mergify mergify bot requested a review from a team September 1, 2020 09:57
Borda
Borda reviewed Sep 1, 2020
View reviewed changes
docs/source/converting.rst Outdated Show resolved Hide resolved
@mergify mergify bot requested a review from a team September 1, 2020 10:27
@rohitgr7 rohitgr7 changed the title Fix batch_outputs with optimizer frequencies [WIP] Fix batch_outputs with optimizer frequencies Sep 1, 2020
@mergify
Copy link
Contributor

mergify bot commented Sep 1, 2020

This pull request is now in conflict... :(

@rohitgr7 rohitgr7 force-pushed the bugfix/opt_freq_batch_update branch from fe043e7 to d6e0fd1 Compare September 1, 2020 17:11
@rohitgr7 rohitgr7 changed the title [WIP] Fix batch_outputs with optimizer frequencies Fix batch_outputs with optimizer frequencies Sep 1, 2020
@rohitgr7 rohitgr7 requested a review from Borda September 1, 2020 17:28
@rohitgr7
Copy link
Contributor Author

rohitgr7 commented Sep 2, 2020

@Borda this one too?

Borda
Borda reviewed Sep 3, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot requested a review from a team September 3, 2020 09:39
Borda
Borda approved these changes Sep 3, 2020
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :]

@Borda Borda added the ready PRs ready to be merged label Sep 3, 2020
@mergify
Copy link
Contributor

mergify bot commented Sep 3, 2020

This pull request is now in conflict... :(

@awaelchli
Copy link
Contributor

awaelchli commented Sep 3, 2020 •
edited
Loading

@rohitgr7 this touches the training loop and @williamFalcon is currently refactoring that. It looks like the training loop will move a separate class (see training_loop_temp.py), so we need to be careful here and coordinate with him. your change is small, so probably not a problem, just saying.

@rohitgr7
Copy link
Contributor Author

rohitgr7 commented Sep 3, 2020

@awaelchli the core training loop is not implemented yet in that file. So I guess either we should block it for some time or merge it now since I don't think the core loop will be changed.

@awaelchli
Copy link
Contributor

agreed

@rohitgr7 rohitgr7 removed the ready PRs ready to be merged label Sep 6, 2020
@rohitgr7 rohitgr7 changed the title Fix batch_outputs with optimizer frequencies [Blocked by refactors]Fix batch_outputs with optimizer frequencies Sep 6, 2020
@mergify
Copy link
Contributor

mergify bot commented Sep 8, 2020

This pull request is now in conflict... :(

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Sep 9, 2020

This pull request is now in conflict... :(

@rohitgr7 rohitgr7 force-pushed the bugfix/opt_freq_batch_update branch from bfe9d74 to bc441c2 Compare September 9, 2020 21:20
@rohitgr7 rohitgr7 changed the title [Blocked by refactors]Fix batch_outputs with optimizer frequencies Fix batch_outputs with optimizer frequencies Sep 9, 2020
@rohitgr7 rohitgr7 added the ready PRs ready to be merged label Sep 9, 2020
@rohitgr7
Copy link
Contributor Author

@Borda can we merge this?

@Borda Borda merged commit a1ea681 into master Sep 10, 2020
@Borda Borda deleted the bugfix/opt_freq_batch_update branch September 10, 2020 21:01
@rohitgr7 rohitgr7 mentioned this pull request Sep 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@Borda Borda Borda approved these changes

@awaelchli awaelchli awaelchli approved these changes

@ananyahjha93 ananyahjha93 Awaiting requested review from ananyahjha93

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

Assignees
No one assigned
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

training multiple optimizers with different frequency Trainer crashed when optimizer frequency is defined.
4 participants
@rohitgr7 @awaelchli @Borda @SkafteNicki