Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: all logging related calls in a connector 1/n #3395

Merged
merged 4 commits into from
Sep 8, 2020
Merged

Conversation

williamFalcon
Copy link
Contributor

No description provided.

@mergify mergify bot requested a review from a team September 8, 2020 11:48
@codecov
Copy link

codecov bot commented Sep 8, 2020

Codecov Report

Merging #3395 into master will decrease coverage by 2%.
The diff coverage is 79%.

@@           Coverage Diff           @@
##           master   #3395    +/-   ##
=======================================
- Coverage      90%     88%    -2%     
=======================================
  Files          97      98     +1     
  Lines        8216    8520   +304     
=======================================
+ Hits         7400    7507   +107     
- Misses        816    1013   +197     

@codecov
Copy link

codecov bot commented Sep 8, 2020

Codecov Report

Merging #3395 into master will increase coverage by 0%.
The diff coverage is 95%.

@@          Coverage Diff           @@
##           master   #3395   +/-   ##
======================================
  Coverage      90%     90%           
======================================
  Files          97      97           
  Lines        8216    8203   -13     
======================================
+ Hits         7400    7402    +2     
+ Misses        816     801   -15     

@williamFalcon williamFalcon changed the title ref: all results+dict actions in a connector 1/n ref: all logging related calls in a connector 1/n Sep 8, 2020
@williamFalcon williamFalcon merged commit 701ca8b into master Sep 8, 2020
@Borda Borda deleted the refa24 branch September 9, 2020 11:04
@Borda Borda added this to the 0.9.x milestone Sep 9, 2020
@Borda Borda added the refactor label Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants