Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ModelCheckpoint monitor to be None #3633

Merged
merged 2 commits into from
Sep 25, 2020
Merged

Allow ModelCheckpoint monitor to be None #3633

merged 2 commits into from
Sep 25, 2020

Conversation

carmocca
Copy link
Contributor

What does this PR do?

Fixes #3620

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

@mergify mergify bot requested a review from a team September 23, 2020 22:45
@codecov
Copy link

codecov bot commented Sep 23, 2020

Codecov Report

Merging #3633 into master will increase coverage by 5%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #3633    +/-   ##
=======================================
+ Coverage      86%     91%    +5%     
=======================================
  Files         110     110            
  Lines        8058    8057     -1     
=======================================
+ Hits         6914    7313   +399     
+ Misses       1144     744   -400     

@Borda Borda added the feature Is an improvement or enhancement label Sep 24, 2020
@Borda
Copy link
Member

Borda commented Sep 24, 2020

seems that the failing tests are unrelated

CHANGELOG.md Show resolved Hide resolved
@mergify mergify bot requested a review from a team September 24, 2020 08:09
@Borda Borda added the ready PRs ready to be merged label Sep 24, 2020
@mergify mergify bot requested a review from a team September 24, 2020 08:10
@mergify mergify bot requested a review from a team September 25, 2020 13:30
@Borda Borda merged commit e70aea7 into Lightning-AI:master Sep 25, 2020
@carmocca carmocca deleted the feature/3620_optional-monitor branch September 25, 2020 13:58
@Borda Borda added this to the 0.9.x milestone Sep 28, 2020
@carmocca carmocca self-assigned this Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModelCheckpoint monitor should be optional
4 participants