enable None model checkpoint default #3669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @williamFalcon! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-09-27 02:39:06 UTC |
williamFalcon
changed the title
ananthsub
reviewed
Sep 26, 2020
| @@ -336,6 +340,13 @@ def on_validation_end(self, trainer, pl_module): | |||
| metrics = trainer.logger_connector.callback_metrics | |||
| epoch = trainer.current_epoch | |||
|
|
|||
| # backward compatibility... need to deprecate | |||
There was a problem hiding this comment.
these need to check if self.monitor is None before resetting it to the older defaults right?
There was a problem hiding this comment.
yup! sorry, i think i removed the WIP too soon haha. but good catch
There was a problem hiding this comment.
ended up just doing a much needed clean up to maintain sanity haha
williamFalcon
commented
Sep 26, 2020
| @@ -513,7 +513,6 @@ def run_sanity_check(self, ref_model): | |||
| self.on_sanity_check_end() | |||
| self.running_sanity_check = False | |||
|
|
|||
| @trainer_state(entering=TrainerState.RUNNING, exiting=TrainerState.FINISHED) | |||
There was a problem hiding this comment.
@Borda let's please get rid of these... makes readability impossible (and IDE inspection)
There was a problem hiding this comment.
ok, we can remove wrappers, just keep the state assignment..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we don't know what to monitor, we are using None as the default going forward.
Now if a user wants to monitor a value, they have to specify a monitor value in the callback.
This is an intermediate step to getting rid of the magic keywords for checkpoint and ES