Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mocking Loggers (part 4a, mlflow) #3884

Merged
merged 2 commits into from
Oct 6, 2020
Merged

Conversation

awaelchli
Copy link
Contributor

Continues effort to use mocking in tests for loggers.
We convert the tests step by step.
The mlflow dependency will be removed in the last PR.

@awaelchli awaelchli changed the title Mocking Loggers (part 4, mlflow) Mocking Loggers (part 4a, mlflow) Oct 5, 2020
@mergify mergify bot requested a review from a team October 5, 2020 23:30
@awaelchli awaelchli added ci Continuous Integration logger Related to the Loggers labels Oct 5, 2020
@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #3884 into master will increase coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #3884    +/-   ##
=======================================
+ Coverage      83%     87%    +4%     
=======================================
  Files         117     117            
  Lines        9155    9154     -1     
=======================================
+ Hits         7623    8001   +378     
+ Misses       1532    1153   -379     

@williamFalcon williamFalcon merged commit 0823cdd into master Oct 6, 2020
@awaelchli awaelchli deleted the tests/mock-mlflow-1 branch October 6, 2020 02:29
@Borda Borda added this to the 0.10.0 milestone Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration logger Related to the Loggers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants