Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moves sync bn to each backend #3925

Merged
merged 1 commit into from
Oct 7, 2020
Merged

moves sync bn to each backend #3925

merged 1 commit into from
Oct 7, 2020

Conversation

williamFalcon
Copy link
Contributor

@williamFalcon williamFalcon commented Oct 7, 2020 •
edited
Loading

moves sync bn to each backend.

Intermediate step. next steps enable backends to be passed in or components of backends as well

@mergify mergify bot requested a review from a team October 7, 2020 01:43
@ananyahjha93 ananyahjha93 self-requested a review October 7, 2020 01:45
ananyahjha93
ananyahjha93 reviewed Oct 7, 2020
View reviewed changes
Copy link
Contributor

@ananyahjha93 ananyahjha93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably define configure_sync_batchnorm for all ddp backends at one place

@mergify mergify bot requested a review from a team October 7, 2020 01:46
@williamFalcon
Copy link
Contributor Author

tomorrow :)

but yes, we will

@williamFalcon williamFalcon merged commit e3007ff into master Oct 7, 2020
@williamFalcon williamFalcon deleted the sbn branch October 7, 2020 04:52
@Borda Borda added this to the 0.10.0 milestone Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananyahjha93 ananyahjha93 ananyahjha93 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
pl:0.10
Development

Successfully merging this pull request may close these issues.
3 participants
@williamFalcon @ananyahjha93 @Borda