Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write progress bar to stdout #531

Merged
merged 2 commits into from
Nov 21, 2019

Conversation

tullie
Copy link
Contributor

@tullie tullie commented Nov 20, 2019

By default tqdm writes the progress bar to stderr. This PR changes the default to write to stdout, which is more sensible.

Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would open a discussion about the output, but I personally do not like having progress bar in stdout since it will interfere with any other logs...

@tullie
Copy link
Contributor Author

tullie commented Nov 20, 2019

Yeah that's fair. Happy to discuss more. Do you think having a trainer parameter that allows you to specify the output file would be okay? Did you want me to start an issue or discuss here?

@williamFalcon williamFalcon merged commit c1ecca4 into Lightning-AI:master Nov 21, 2019
@tullie tullie deleted the progress-bar-stdout branch November 21, 2019 18:42
@Borda
Copy link
Member

Borda commented Nov 21, 2019

Heh... :-D

@seannz
Copy link

seannz commented May 25, 2021

Sorry to revive an old thread, but I think it's much more sensible to write the tqdm output to stderr.

This way, we can redirect the training script output to a log file without cluttering it with tqdm progress bars. You can always redirect stderr to stdout in the shell itself if writing tqdm progress bars to stdout is absolutely needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants