Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add option for multiple inputs when writing weight summary #543

Merged
merged 1 commit into from
Dec 9, 2019
Merged

add option for multiple inputs when writing weight summary #543

merged 1 commit into from
Dec 9, 2019
+16 −5

Conversation

VSJMilewski
Copy link
Contributor

@VSJMilewski VSJMilewski commented Nov 25, 2019 •
edited
Loading

Before submitting

What does this PR do?

Fixes #537

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃
yes

jeffling
jeffling reviewed Nov 25, 2019
View reviewed changes
pytorch_lightning/root_module/memory.py Outdated Show resolved Hide resolved
pytorch_lightning/root_module/memory.py Outdated Show resolved Hide resolved
@VSJMilewski
Copy link
Contributor Author

Maybe this is also the correct PR to work on issue #518 ? For me it wasn't printing the summary either.
However, I'm not sure what the issue could be.Does anybody have some ideas?

@jeffling
Copy link
Contributor

The issue there seems specific logging levels, so if you set your logging level to INFO you should see the summary.

BTW, looks like this branch needs a merge/rebase from master (rebase preferred if possible)

@williamFalcon
Copy link
Contributor

@VSJMilewski @Ir1d can we rebase and merge this PR?

@Borda
Copy link
Member

Borda commented Dec 8, 2019

@VSJMilewski rebase master, pls...

@VSJMilewski
Copy link
Contributor Author

Sorry @Borda, I've been very busy.

@Borda
Copy link
Member

Borda commented Dec 9, 2019

@VSJMilewski it seems that you just merged master with many other commits, please do rebase...
https://git-scm.com/book/en/v2/Git-Branching-Rebasing
or you can consider also cherry-pick from master

@VSJMilewski VSJMilewski closed this Dec 9, 2019
@VSJMilewski VSJMilewski reopened this Dec 9, 2019
Borda
Borda reviewed Dec 9, 2019
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about getting next device index, otherwise it LGTM

pytorch_lightning/core/memory.py
@@ -50,20 +50,31 @@ def get_variable_sizes(self):
input_ = self.model.example_input_array

if self.model.on_gpu:
input_ = input_.cuda(0)
device = next(self.model.parameters()).get_device()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not very sure about this getting device...
Probably also check if there is a next one?

@williamFalcon williamFalcon merged commit d562172 into Lightning-AI:master Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda left review comments

@jeffling jeffling jeffling left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Summary not working for model on GPU with multiple inputs
4 participants
@VSJMilewski @jeffling @williamFalcon @Borda