TPU Spawn Rank & root device Error #7074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7074 +/- ##
========================================
Coverage ? 87%
========================================
Files ? 196
Lines ? 12573
Branches ? 0
========================================
Hits ? 10942
Misses ? 1631
Partials ? 0 |
kaushikb11
requested review from
awaelchli,
justusschock,
SeanNaren and
tchaton
as code owners
kaushikb11
added
accelerator: tpu
awaelchli
approved these changes
Apr 18, 2021
| @@ -65,6 +65,10 @@ def local_rank(self) -> int: | |||
| def world_size(self) -> int: | |||
| return self.num_processes | |||
|
|
|||
| @property | |||
| def root_device(self) -> torch.device: | |||
| return self.device | |||
There was a problem hiding this comment.
Is it correct, we aren't allowed to call xm.xla_device() here before we have spawned the processes?
There was a problem hiding this comment.
@awaelchli I don't think it would be required to call root_device outside the new processes.
kaushikb11
requested review from
Borda,
carmocca and
williamFalcon
as code owners
SeanNaren
approved these changes
Apr 18, 2021
kaushikb11
added a commit
to kaushikb11/pytorch-lightning
that referenced
this pull request
Apr 20, 2021
* TPU Spawn Rank Error * Update tpu spawn * Fix root device property for tpu spawn * Update changelog
lexierule
pushed a commit
that referenced
this pull request
Apr 22, 2021
* TPU Spawn Rank Error * Update tpu spawn * Fix root device property for tpu spawn * Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #7086
Fixes #7088
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃