Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Properly name PyTorchProfiler traces #8009

Merged
merged 11 commits into from
Jun 18, 2021
Merged

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Jun 16, 2021

What does this PR do?

This PR properly traces generated with PyTorch Profiler.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton added the bug Something isn't working label Jun 16, 2021
@tchaton tchaton added this to the v1.3.x milestone Jun 16, 2021
@tchaton tchaton self-assigned this Jun 16, 2021
@pep8speaks
Copy link

pep8speaks commented Jun 16, 2021

Hello @tchaton! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-06-18 17:53:00 UTC

@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #8009 (831bd17) into master (e55f01e) will decrease coverage by 0%.
The diff coverage is 91%.

@@          Coverage Diff           @@
##           master   #8009   +/-   ##
======================================
- Coverage      92%     91%   -0%     
======================================
  Files         210     210           
  Lines       13576   13579    +3     
======================================
- Hits        12449   12414   -35     
- Misses       1127    1165   +38     

pytorch_lightning/profiler/base.py Outdated Show resolved Hide resolved
pytorch_lightning/profiler/base.py Outdated Show resolved Hide resolved
pytorch_lightning/profiler/pytorch.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot removed the has conflicts label Jun 18, 2021
@carmocca carmocca enabled auto-merge (squash) June 18, 2021 17:31
@carmocca carmocca added the ready PRs ready to be merged label Jun 18, 2021
@carmocca carmocca merged commit 651a0fb into master Jun 18, 2021
@carmocca carmocca deleted the pytorch_profiler_names branch June 18, 2021 18:16
awaelchli added a commit that referenced this pull request Jun 22, 2021
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
lexierule pushed a commit that referenced this pull request Jun 22, 2021
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working profiler ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants