-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure parsing flow in the LightningCLI
#8721
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
added
refactor
argparse (removed)
Related to argument parsing (argparse, Hydra, ...)
labels
Aug 4, 2021
Codecov Report
@@ Coverage Diff @@
## master #8721 +/- ##
=======================================
- Coverage 93% 89% -4%
=======================================
Files 169 169
Lines 14072 14073 +1
=======================================
- Hits 13043 12468 -575
- Misses 1029 1605 +576 |
carmocca
requested review from
awaelchli,
Borda,
justusschock,
kaushikb11,
SeanNaren,
tchaton and
williamFalcon
as code owners
August 4, 2021 18:39
awaelchli
approved these changes
Aug 5, 2021
mauvilsa
approved these changes
Aug 6, 2021
Borda
approved these changes
Aug 9, 2021
tchaton
approved these changes
Aug 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
four4fish
pushed a commit
to four4fish/pytorch-lightning
that referenced
this pull request
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
argparse (removed)
Related to argument parsing (argparse, Hydra, ...)
ready
PRs ready to be merged
refactor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Splitting of some of the changes from #7508
seed_everything
optionalDoes your PR introduce any breaking changes? If yes, please list them.
LightningCLI
is beta, but these are the non-BC changesinit_parser
now returns the parser instance.add_core_arguments_to_parser
,parse_arguments
now take aparser
argumentinstantiate_trainer
now takes a config and a list of callbacks.add_core_arguments_to_parser
intoadd_default_arguments_to_parser
+add_core_arguments_to_parser
Before submitting
PR review
cc @mauvilsa