-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce CheckpointIO Plugin #8743
Conversation
Hello @SeanNaren! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-08-13 11:28:41 UTC |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this idea <3
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #8743 +/- ##
======================================
Coverage 93% 93%
======================================
Files 169 172 +3
Lines 14061 14148 +87
======================================
+ Hits 13033 13118 +85
- Misses 1028 1030 +2 |
My plan:
|
pytorch_lightning/plugins/training_type/training_type_plugin.py
Outdated
Show resolved
Hide resolved
pytorch_lightning/plugins/training_type/training_type_plugin.py
Outdated
Show resolved
Hide resolved
pytorch_lightning/plugins/training_type/training_type_plugin.py
Outdated
Show resolved
Hide resolved
@ananthsub Maybe marking it experimental in changelog + docstring of plugin class? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @SeanNaren
looks like a great addition
as @awaelchli suggested I'll add some docstrings, however I also think this should go into the docs just like other features we have for discoverability. Would people be against this? |
pytorch_lightning/plugins/training_type/training_type_plugin.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome work @SeanNaren !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
What does this PR do?
Closes #8118.
This is a V0 where we've abstracted the checkpointing logic into a class that eventually can be plugged in via the trainer.
Few outstanding issues that I'll tag throughout the PR!
The goal is to be able to do this:
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃