-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Detach Loaders after running entrypoint #8885
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8885 +/- ##
======================================
Coverage 93% 93%
======================================
Files 169 169
Lines 14079 14098 +19
======================================
+ Hits 13053 13072 +19
Misses 1026 1026 |
@ananthsub This is a short-term fix for the issue, which still does not resolve #6030 . However, I think we should do this in a separate PR after discussion on how we do it instead, which is why I sent this fix :) |
carmocca
reviewed
Aug 13, 2021
tchaton
approved these changes
Aug 13, 2021
ananthsub
approved these changes
Aug 13, 2021
…torch-lightning into bug/loader_detaching
carmocca
reviewed
Aug 13, 2021
awaelchli
approved these changes
Aug 13, 2021
Borda
approved these changes
Aug 14, 2021
four4fish
pushed a commit
to four4fish/pytorch-lightning
that referenced
this pull request
Aug 16, 2021
detach loaders after run
kaushikb11
pushed a commit
to kaushikb11/pytorch-lightning
that referenced
this pull request
Aug 18, 2021
detach loaders after run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #8868
Restores the original dataloaders after the entrypoint if replaced during the run.
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃