Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Detach Loaders after running entrypoint #8885

Merged
merged 5 commits into from
Aug 16, 2021

Conversation

justusschock
Copy link
Member

@justusschock justusschock commented Aug 13, 2021

What does this PR do?

Fixes #8868

Restores the original dataloaders after the entrypoint if replaced during the run.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #8885 (a1753ab) into master (4b6aaee) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #8885   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         169     169           
  Lines       14079   14098   +19     
======================================
+ Hits        13053   13072   +19     
  Misses       1026    1026           

@justusschock
Copy link
Member Author

justusschock commented Aug 13, 2021

@ananthsub This is a short-term fix for the issue, which still does not resolve #6030 .

However, I think we should do this in a separate PR after discussion on how we do it instead, which is why I sent this fix :)

@mergify mergify bot added the ready PRs ready to be merged label Aug 13, 2021
@carmocca carmocca added this to the v1.4.x milestone Aug 13, 2021
@carmocca carmocca added bug Something isn't working data handling Generic data-related topic labels Aug 13, 2021
@Borda Borda requested a review from carmocca August 14, 2021 06:33
@justusschock justusschock merged commit 1d2f7e2 into master Aug 16, 2021
@justusschock justusschock deleted the bug/loader_detaching branch August 16, 2021 07:26
four4fish pushed a commit to four4fish/pytorch-lightning that referenced this pull request Aug 16, 2021
kaushikb11 pushed a commit to kaushikb11/pytorch-lightning that referenced this pull request Aug 18, 2021
lexierule pushed a commit that referenced this pull request Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data handling Generic data-related topic ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Predicting with custom dataloader overwrites "predict_dataloader()" method of module
6 participants