-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove reference to DistributedDataParallel from parallel plugin teardown #8943
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8943 +/- ##
=======================================
- Coverage 92% 88% -4%
=======================================
Files 176 176
Lines 14790 14673 -117
=======================================
- Hits 13638 12894 -744
- Misses 1152 1779 +627 |
fbd5a83
to
a6c21b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! But I believe we already have test for this.
Remove the unit test as it's already covered. Will add more unit test if it's needed after #9096 |
What does this PR do?
Parallel plugin should be generic and self-contained. Move reference to DistributedDataParallel from parallel teardown()
Subtask 1 for "remove reference to DistributedDataParallel from parallel plugin"
Tests:
python -m pytest -v tests/plugins/test_ddp_spawn_plugin.py passed
dev python -m pytest -v tests/plugins/test_ddp_plugin.py passed
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃