Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DeepSpeed Stage 1 + doc improvements for model parallel #8974

Merged
merged 3 commits into from
Aug 18, 2021

Conversation

SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Aug 18, 2021

What does this PR do?

Adds DeepSpeed Stage 1 as a configuration + improvements/additions to the doc. This is required for the Torch ORT integration.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@SeanNaren SeanNaren self-assigned this Aug 18, 2021
@SeanNaren SeanNaren added docs Documentation related feature Is an improvement or enhancement labels Aug 18, 2021
@SeanNaren SeanNaren added this to the v1.5 milestone Aug 18, 2021
@SeanNaren SeanNaren added the 3rd party Related to a 3rd-party label Aug 18, 2021
@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #8974 (47ba7b1) into master (38ceb89) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #8974   +/-   ##
======================================
  Coverage      89%     89%           
======================================
  Files         176     176           
  Lines       14411   14412    +1     
======================================
+ Hits        12772   12773    +1     
  Misses       1639    1639           

@tchaton tchaton added the ready PRs ready to be merged label Aug 18, 2021
@SeanNaren SeanNaren enabled auto-merge (squash) August 18, 2021 13:20
@SeanNaren SeanNaren merged commit c6b6888 into master Aug 18, 2021
@SeanNaren SeanNaren deleted the feat/stage_1 branch August 18, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party Related to a 3rd-party docs Documentation related feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants