Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset datafetcher references in teardown #9387

Merged
merged 11 commits into from
Sep 15, 2021

Conversation

ananthsub
Copy link
Contributor

@ananthsub ananthsub commented Sep 9, 2021

What does this PR do?

Very similar to #9386. While the data connector calls the teardown, it doesn't actually reset these, which can be an issue because of the references the data fetcher itself holds

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@ananthsub ananthsub changed the title [loops] Reset datafetcher references in teardown Reset datafetcher references in teardown Sep 9, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Sep 9, 2021
@awaelchli awaelchli enabled auto-merge (squash) September 9, 2021 21:41
@awaelchli awaelchli added this to the v1.5 milestone Sep 9, 2021
@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #9387 (eea9530) into master (83bff01) will decrease coverage by 4%.
The diff coverage is 100%.

❗ Current head eea9530 differs from pull request most recent head 0473767. Consider uploading reports for the commit 0473767 to get more accurate results

@@           Coverage Diff           @@
##           master   #9387    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         180     179     -1     
  Lines       15062   14931   -131     
=======================================
- Hits        13983   13259   -724     
- Misses       1079    1672   +593     

@mergify mergify bot removed the has conflicts label Sep 12, 2021
@ananthsub ananthsub disabled auto-merge September 14, 2021 15:50
@ananthsub ananthsub merged commit 20ebb5c into Lightning-AI:master Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants