-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add is_last_batch
to progress tracking
#9657
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
requested review from
awaelchli,
Borda,
justusschock,
kaushikb11,
SeanNaren,
tchaton and
williamFalcon
as code owners
September 23, 2021 01:29
carmocca
added
progress tracking (internal)
Related to the progress tracking dataclasses
and removed
fault tolerance
labels
Sep 23, 2021
Codecov Report
@@ Coverage Diff @@
## master #9657 +/- ##
======================================
Coverage 93% 93%
======================================
Files 179 179
Lines 15324 15313 -11
======================================
- Hits 14216 14207 -9
+ Misses 1108 1106 -2 |
tchaton
approved these changes
Sep 23, 2021
awaelchli
approved these changes
Sep 23, 2021
for more information, see https://pre-commit.ci
SeanNaren
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
progress tracking (internal)
Related to the progress tracking dataclasses
ready
PRs ready to be merged
refactor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Required for #9563
Minor docstring fixes are included
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review