Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_last_batch to progress tracking #9657

Merged
merged 10 commits into from
Sep 23, 2021
Merged

Add is_last_batch to progress tracking #9657

merged 10 commits into from
Sep 23, 2021

Conversation

carmocca
Copy link
Contributor

What does this PR do?

Required for #9563

Minor docstring fixes are included

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added this to the v1.5 milestone Sep 23, 2021
@carmocca carmocca self-assigned this Sep 23, 2021
@carmocca carmocca marked this pull request as ready for review September 23, 2021 01:29
@carmocca carmocca added progress tracking (internal) Related to the progress tracking dataclasses and removed fault tolerance labels Sep 23, 2021
@codecov
Copy link

codecov bot commented Sep 23, 2021

Codecov Report

Merging #9657 (800ab6b) into master (ca5459e) will increase coverage by 0%.
The diff coverage is 100%.

❗ Current head 800ab6b differs from pull request most recent head fdb868b. Consider uploading reports for the commit fdb868b to get more accurate results

@@          Coverage Diff           @@
##           master   #9657   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         179     179           
  Lines       15324   15313   -11     
======================================
- Hits        14216   14207    -9     
+ Misses       1108    1106    -2     

tests/trainer/test_trainer.py Outdated Show resolved Hide resolved
@mergify mergify bot added ready PRs ready to be merged has conflicts labels Sep 23, 2021
@mergify mergify bot removed the has conflicts label Sep 23, 2021
@carmocca carmocca enabled auto-merge (squash) September 23, 2021 12:46
@carmocca carmocca merged commit 8dcba38 into master Sep 23, 2021
@carmocca carmocca deleted the feat/save-last-batch branch September 23, 2021 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
progress tracking (internal) Related to the progress tracking dataclasses ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants