-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2/4] Add DeviceStatsMonitor callback #9712
[2/4] Add DeviceStatsMonitor callback #9712
Conversation
…lightning into get_device_stats
for more information, see https://pre-commit.ci
…ightning into get_device_stats
for more information, see https://pre-commit.ci
…ightning into dstats_callback
…ightning into get_device_stats
…ightning into dstats_callback
for more information, see https://pre-commit.ci
…ightning into get_device_stats
…ightning into dstats_callback
Co-authored-by: thomas chaton <thomas@grid.ai>
Co-authored-by: thomas chaton <thomas@grid.ai>
for more information, see https://pre-commit.ci
thanks so much @kaushikb11 for fixing the tpu test failure!!! |
[RESOLVED] Does anyone have any suggestions to solve the mypy error in a clean way? https://github.com/PyTorchLightning/pytorch-lightning/pull/9712/checks?check_run_id=3875669398 |
[RESOLVED - we decided |
Also is there anything I can do about the "Abstract method not overridden" Python errors? https://deepsource.io/gh/PyTorchLightning/pytorch-lightning/run/36c8f43c-2cab-40b2-b81f-6edd6c439a43/python/PYL-W0223 Do we definitely want LightningLoggerBase to be an ABC? cc @carmocca |
It might be okay to remove - it was added without a strong argument for it: #605 perhaps @justusschock or @awaelchli have a preference? |
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com> Co-authored-by: thomas chaton <thomas@grid.ai> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> Co-authored-by: Kaushik B <kaushikbokka@gmail.com> Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
I think we don't want the LoggerBase to be a logger that people can instantiate and use. That would be silly:
or what would be the benefit? |
Nevermind, I agree that doesn't make sense. The initial motivation was to fix a DeepSource error from a test class, but we can consider this resolved. |
What does this PR do?
Adds DeviceStatsMonitor callback which calls the get_device_stats function in Accelerator interface. DeviceStatsMonitor will replace GPUStatsMonitor and XLAStatsMonitor
Part of #9032
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃