-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Deepspeed and lightning calling scheduler #9788
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanNaren
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
kaushikb11,
rohitgr7,
tchaton and
williamFalcon
as code owners
October 1, 2021 11:41
tchaton
approved these changes
Oct 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT !
awaelchli
approved these changes
Oct 1, 2021
rohitgr7
approved these changes
Oct 1, 2021
Codecov Report
@@ Coverage Diff @@
## master #9788 +/- ##
======================================
Coverage 93% 93%
======================================
Files 177 177
Lines 15460 15465 +5
======================================
+ Hits 14323 14328 +5
Misses 1137 1137 |
carmocca
reviewed
Oct 1, 2021
leezu
pushed a commit
to leezu/pytorch-lightning
that referenced
this pull request
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #9771
After speaking to @tchaton we decided to remove the scheduler responsibility from DeepSpeed, fully relying on Lightning to control when to call the lr scheduler step function. This also allows users to use epoch vs step calls which is not possible in DeepSpeed.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃