Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Deepspeed and lightning calling scheduler #9788

Merged
merged 3 commits into from
Oct 1, 2021

Conversation

SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Oct 1, 2021

What does this PR do?

Fixes #9771

After speaking to @tchaton we decided to remove the scheduler responsibility from DeepSpeed, fully relying on Lightning to control when to call the lr scheduler step function. This also allows users to use epoch vs step calls which is not possible in DeepSpeed.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@SeanNaren SeanNaren added the bug Something isn't working label Oct 1, 2021
@SeanNaren SeanNaren added this to the v1.4.x milestone Oct 1, 2021
@SeanNaren SeanNaren self-assigned this Oct 1, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

@mergify mergify bot added the ready PRs ready to be merged label Oct 1, 2021
@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #9788 (43a910a) into master (9d98208) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #9788   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         177     177           
  Lines       15460   15465    +5     
======================================
+ Hits        14323   14328    +5     
  Misses       1137    1137           

@SeanNaren SeanNaren enabled auto-merge (squash) October 1, 2021 14:00
@SeanNaren SeanNaren merged commit 38f8029 into master Oct 1, 2021
@SeanNaren SeanNaren deleted the fix/deepspeed_scheduler branch October 1, 2021 14:35
leezu pushed a commit to leezu/pytorch-lightning that referenced this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeepSpeed & Lightning are both calling the scheduler
5 participants