Removed a redundant warning with `ModelCheckpoint(monitor=None)` callback #9875

Programmer-RD-AI · 2021-10-09T06:28:07Z

Fixes

What does this PR do?

Fixes #9868

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

Was this discussed/approved via a GitHub issue? (not for typos and docs) Warning recommend save_top_k=None but it crash training #9868
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary) I don't think this small fix needs to be updated in the docs
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

##Changes
pytorch_lightning/callbacks/model_checkpoint.py
150 Line Change
432 Line Change

Check the code that was changed in the files changed tab of this pull request.

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet list:

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Yes, It was a new experience for me for contributing to a project.
It was fun,
And I am looking forward to helping the PyTorch Community.

Regards,
Ranuga

for more information, see https://pre-commit.ci

awaelchli · 2021-10-10T19:35:48Z

@Programmer-RD-AI Please keep the PR template :) (see checklists)

pytorch_lightning/callbacks/model_checkpoint.py

codecov · 2021-10-10T19:52:20Z

Codecov Report

Merging #9875 (4a51af5) into master (2f31328) will decrease coverage by 4%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #9875    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         178     178            
  Lines       15620   15649    +29     
=======================================
- Hits        14477   13868   -609     
- Misses       1143    1781   +638

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

Programmer-RD-AI · 2021-10-11T01:59:39Z

@Programmer-RD-AI Please keep the PR template :) (see checklists)

ok @awaelchli

Regards

Programmer-RD-AI · 2021-10-11T02:17:51Z

tchaton

LGTM !

pytorch_lightning/callbacks/model_checkpoint.py

for more information, see https://pre-commit.ci

…back (Lightning-AI#9875) * Update README.md * Update README.md * Create evaluation.py * Update README.md * Update evaluation.py * Create evaluation.py * Create evaluation.py * Update evaluation.py * Create nlp.py * Update evaluation.py * Create evaluation.py * Update nlp.py * Update nlp.py * Update evaluation.py * Create evaluation.py * Update nlp.py * Update nlp.py * Update requirements.txt * Update evaluation.py * Create data_loader.py * Update nlp.py * Update evaluation.py * Update data_loader.py * Update nlp.py * Update data_loader.py * Update requirements.txt * Update model_checkpoint.py * Delete evaluation.py * Delete data_loader.py * Delete nlp.py * Update requirements.txt * Update model_checkpoint.py * Update README.md * Update pytorch_lightning/callbacks/model_checkpoint.py * Update CHANGELOG.md * Update test_model_checkpoint.py * Update model_checkpoint.py * update * update * chlog update Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

Programmer-RD-AI and others added 30 commits October 6, 2021 20:25

Update README.md

74e5364

Update README.md

e0af7c2

[pre-commit.ci] auto fixes from pre-commit.com hooks

b2a1372

for more information, see https://pre-commit.ci

Create evaluation.py

864b400

[pre-commit.ci] auto fixes from pre-commit.com hooks

9e74636

for more information, see https://pre-commit.ci

Update README.md

818e5fe

Update evaluation.py

5f86d08

[pre-commit.ci] auto fixes from pre-commit.com hooks

2413629

for more information, see https://pre-commit.ci

Create evaluation.py

d004722

[pre-commit.ci] auto fixes from pre-commit.com hooks

741bec7

for more information, see https://pre-commit.ci

Create evaluation.py

725b1cc

[pre-commit.ci] auto fixes from pre-commit.com hooks

646c929

for more information, see https://pre-commit.ci

Update evaluation.py

8f4916c

Create nlp.py

543195c

[pre-commit.ci] auto fixes from pre-commit.com hooks

c08ed59

for more information, see https://pre-commit.ci

Update evaluation.py

d22b3a4

Create evaluation.py

992023d

Update nlp.py

28a7670

Update nlp.py

4751e27

Update evaluation.py

f727207

Create evaluation.py

e3a3acc

Update nlp.py

c410db0

Update nlp.py

03a5dcc

Update requirements.txt

e053747

[pre-commit.ci] auto fixes from pre-commit.com hooks

267085a

for more information, see https://pre-commit.ci

Update evaluation.py

78528a0

[pre-commit.ci] auto fixes from pre-commit.com hooks

8510097

for more information, see https://pre-commit.ci

Create data_loader.py

3981c0f

[pre-commit.ci] auto fixes from pre-commit.com hooks

577e746

for more information, see https://pre-commit.ci

Update nlp.py

bf7315c

Update README.md

2162f62

awaelchli changed the title ~~#9868 bug solve~~ Fix save_top_k warning in ModelCheckpoint callback Oct 10, 2021

awaelchli reviewed Oct 10, 2021

View reviewed changes

pytorch_lightning/callbacks/model_checkpoint.py Outdated Show resolved Hide resolved

pytorch_lightning/callbacks/model_checkpoint.py Outdated Show resolved Hide resolved

Update pytorch_lightning/callbacks/model_checkpoint.py

83f379e

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

Programmer-RD-AI added 2 commits October 11, 2021 07:56

Update CHANGELOG.md

fecfbc8

Merge branch 'PyTorchLightning:master' into master

7086701

tchaton approved these changes Oct 11, 2021

View reviewed changes

rohitgr7 reviewed Oct 11, 2021

View reviewed changes

pytorch_lightning/callbacks/model_checkpoint.py Outdated Show resolved Hide resolved

Programmer-RD-AI and others added 7 commits October 11, 2021 15:59

Update test_model_checkpoint.py

3dc3337

[pre-commit.ci] auto fixes from pre-commit.com hooks

a3e7581

for more information, see https://pre-commit.ci

Update model_checkpoint.py

acf6e28

[pre-commit.ci] auto fixes from pre-commit.com hooks

73c0ae9

for more information, see https://pre-commit.ci

update

c56bcb8

update

ad6259d

chlog update

4a51af5

rohitgr7 changed the title ~~Fix save_top_k warning in ModelCheckpoint callback~~ Removed a redundant warning with ModelCheckpoint(monitor=None) callback Oct 11, 2021

awaelchli added the bug Something isn't working label Oct 11, 2021

awaelchli added this to the v1.4.x milestone Oct 11, 2021

awaelchli approved these changes Oct 11, 2021

View reviewed changes

mergify bot added the ready PRs ready to be merged label Oct 11, 2021

SkafteNicki approved these changes Oct 11, 2021

View reviewed changes

SkafteNicki enabled auto-merge (squash) October 11, 2021 14:09

carmocca approved these changes Oct 11, 2021

View reviewed changes

SkafteNicki merged commit f915a8a into Lightning-AI:master Oct 11, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removed a redundant warning with `ModelCheckpoint(monitor=None)` callback #9875

Removed a redundant warning with `ModelCheckpoint(monitor=None)` callback #9875

Programmer-RD-AI commented Oct 9, 2021 •

edited

Loading

awaelchli commented Oct 10, 2021 •

edited

Loading

codecov bot commented Oct 10, 2021 •

edited

Loading

Programmer-RD-AI commented Oct 11, 2021

Programmer-RD-AI commented Oct 11, 2021

What does this PR do?

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

PR review

Did you have fun?

tchaton left a comment

Removed a redundant warning with ModelCheckpoint(monitor=None) callback #9875

Removed a redundant warning with ModelCheckpoint(monitor=None) callback #9875

Conversation

Programmer-RD-AI commented Oct 9, 2021 • edited Loading

What does this PR do?

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

PR review

Did you have fun?

awaelchli commented Oct 10, 2021 • edited Loading

codecov bot commented Oct 10, 2021 • edited Loading

Codecov Report

Programmer-RD-AI commented Oct 11, 2021

Programmer-RD-AI commented Oct 11, 2021

What does this PR do?

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

PR review

Did you have fun?

tchaton left a comment

Choose a reason for hiding this comment

Removed a redundant warning with `ModelCheckpoint(monitor=None)` callback #9875

Removed a redundant warning with `ModelCheckpoint(monitor=None)` callback #9875

Programmer-RD-AI commented Oct 9, 2021 •

edited

Loading

awaelchli commented Oct 10, 2021 •

edited

Loading

codecov bot commented Oct 10, 2021 •

edited

Loading