-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2/n] Directly call TrainingTypePlugin APIs instead of going through the Accelerator #9901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
four4fish
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
kaushikb11,
rohitgr7,
SeanNaren,
tchaton and
williamFalcon
as code owners
October 12, 2021 00:46
tchaton
approved these changes
Oct 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM !
Codecov Report
@@ Coverage Diff @@
## master #9901 +/- ##
=======================================
- Coverage 93% 89% -4%
=======================================
Files 179 179
Lines 15745 15770 +25
=======================================
- Hits 14597 13993 -604
- Misses 1148 1777 +629 |
four4fish
force-pushed
the
imp/acce
branch
3 times, most recently
from
October 12, 2021 19:37
f12eb07
to
e3c9f22
Compare
awaelchli
approved these changes
Oct 13, 2021
carmocca
approved these changes
Oct 14, 2021
9 tasks
carmocca
added a commit
that referenced
this pull request
Oct 15, 2021
9 tasks
tchaton
pushed a commit
that referenced
this pull request
Oct 16, 2021
rohitgr7
pushed a commit
to Tshimanga/pytorch-lightning
that referenced
this pull request
Oct 18, 2021
…the Accelerator (Lightning-AI#9901) Co-authored-by: tchaton <thomas@grid.ai>
rohitgr7
pushed a commit
to Tshimanga/pytorch-lightning
that referenced
this pull request
Oct 18, 2021
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
[[1/n] Call training_type_plugin collective functions directly instead of going through the Accelerator]
(#9677)
Fixes #9426
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃