Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Grouped Radiator Valves Do Not Show #148

Open
AstersikRoss opened this issue Nov 2, 2023 · 6 comments
Open

[BUG] Grouped Radiator Valves Do Not Show #148

AstersikRoss opened this issue Nov 2, 2023 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@AstersikRoss
Copy link

Describe the bug
Hive Radiator valves that are in a group do not show as individual valves or as a group. This means there is no way to control them in Home Assistant.

To Reproduce
Steps to reproduce the behaviour:

  1. Group two or more valves in the Hive app
  2. Sign into Hive via the Home Assistant Integration
  3. View devices, only single valves are listed.

Expected behaviour
We would expect to see either the group of valves under one control or a group and individual valves

@AstersikRoss AstersikRoss added the bug Something isn't working label Nov 2, 2023
@MPSwitch
Copy link

Unfortunately doesn't look like this is active, having the same issue :(

@cpether
Copy link
Contributor

cpether commented Feb 12, 2024

I've created a PR to fix this, all you have to do is bump the version of pyhiveapi that it's using. Not sure if anyone is going to merge it in, but you can update it yourself in HA if you want to fix the issue.

#153

@MPSwitch
Copy link

Sorry to sound silly, if this isn’t being monitored or updated to implement the new change is it a case of just changing the files you’ve changed in the PR?

@cpether
Copy link
Contributor

cpether commented Feb 12, 2024

Yes, i just used file editor in HA and changed the files then did a restart and it all worked. Or you can copy the files from my forked repo if you want: https://github.com/cpether/Hive-Custom-Component

@MPSwitch
Copy link

Cheers @cpether I have modified the file, my TRVs now show individually, i.e. Living Room Front and Living Room Back, and the controls for them appear on the first TRV in the group in the Hive app, i.e. no controls on Living Room Back but all the usual controls on Living Room Front. This looks to be just the solution! Many thanks, just read your forks documentation page, would it be possible to reset up my Hive integration with your fork specifically and have this all working? Excuse my limited knowledge of git, fairly new to all this.

@cpether
Copy link
Contributor

cpether commented Feb 13, 2024

it's been merged now, so you can just update this component in HACS to pick up the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants