-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for AimTTi QL355TP #5021
Conversation
@AdamVerner thank you! would you mind adding a
( this is mentioned in our contribution docs https://qcodes.github.io/Qcodes/community/contributing.html#pull-requests ) |
Codecov Report
@@ Coverage Diff @@
## master #5021 +/- ##
=======================================
Coverage 67.22% 67.22%
=======================================
Files 356 357 +1
Lines 29730 29733 +3
=======================================
+ Hits 19985 19988 +3
Misses 9745 9745 |
@AdamVerner we have standadized on having an explicit class for each driver and having these exposed at the top level. Looking at https://github.com/QCoDeS/Qcodes/tree/master/qcodes/instrument_drivers/AimTTi and https://github.com/QCoDeS/Qcodes/blob/master/qcodes/instrument_drivers/AimTTi/__init__.py could you add a class for the new driver to the init file similar to the other drivers |
Thanks i have added those changes. I also rebased back onto master so it's easier to merge. |
Hi,
I have added AimTTi QL355TP power supply.
I also moved the lookup table for other power supplies in case someone wants to easily add his device.