Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bug where in masked_lm transformations only subwords were candidates for top_words #417

Merged
merged 19 commits into from
Feb 15, 2021
Merged

Fixed bug where in masked_lm transformations only subwords were candidates for top_words #417

merged 19 commits into from
Feb 15, 2021

Conversation

alexander-zap
Copy link
Contributor

@alexander-zap alexander-zap commented Feb 10, 2021 •
edited
Loading

What does this PR do?

Summary

  • This PR fixes a bug, where in masked_lm transformations only subwords were candidates for top_words.

Changes

  • This bug is fixed by a change in identation. The files changed are word_swap_masked_lm.py, word_merge_masked_lm.py, word_insertion_masked_lm.py.

Checklist

  • [ X ] The title of your pull request should be a summary of its contribution.
  • [ X ] Please write detailed description of what parts have been newly added and what parts have been modified. Please also explain why certain changes were made.
  • [ X ] If your pull request addresses an issue, please mention the issue number in the pull request description to make sure they are linked (and people consulting the issue know you are working on it)
  • [ X ] To indicate a work in progress please mark it as a draft on Github.
  • [ ] Make sure existing tests pass.
  • [ X ] Add relevant tests. No quality testing = no merge.
  • [ X ] All public methods must have informative docstrings that work nicely with sphinx. For new modules/files, please add/modify the appropriate .rst file in TextAttack/docs/apidoc.'

alexander.zap and others added 2 commits February 10, 2021 11:02
Fixed bug where only subwords were candidates for top_words
b0a9c97
@tk-dev11
Update README.md
3828c74 
Added the Table comparing TextAttack models with paperswithcode.com SOTA, organized by NLP tasks
jinyongyoo
jinyongyoo approved these changes Feb 11, 2021
View reviewed changes
Copy link
Collaborator

@jinyongyoo jinyongyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good catch

@qiyanjun
Copy link
Member

please rebase

qiyanjun and others added 13 commits February 13, 2021 15:51
@qiyanjun
Update README.md
aa2ccb5
@qiyanjun
reduce font of Model/readme.md
4019eb1
@qiyanjun
make all url smaller font in models/readme.md
29bf26f
@qiyanjun
fix minor errors
e32476a
@qiyanjun
add more details in the model page on readthedoc
20f79e1
@qiyanjun
add in sphinx-markdown-tables
47a03e3
@qiyanjun
Merge pull request #419 from tahmid-kazi/patch-4
2009a77 
Update Model Zoo README.md with NLP Tasks table
@qiyanjun
sphinx-markdown-tables runs fine on readthedoc , but not in Github Wo…
2884cbf 
…rkflow..
@qiyanjun
bypass the sphinx issue on ubuntu-latest to ubuntu-18.04
91e364a
@qiyanjun
Revert "bypass the sphinx issue on ubuntu-latest to ubuntu-18.04"
c2bc09f 
This reverts commit 91e364a.
@qiyanjun
Update requirements.txt
5780b17 
add sphinx-markdown-tables in dependency
Fixed bug where only subwords were candidates for top_words
86a3d31
Merge remote-tracking branch 'origin/fix_transformation_masked_lm' in…
203dba9 
…to fix_transformation_masked_lm
@jinyongyoo jinyongyoo merged commit eebf207 into QData:master Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinyongyoo jinyongyoo jinyongyoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexander-zap @qiyanjun @jinyongyoo @tk-dev11