Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using outside of network, Images not working #28

Closed
diamkil opened this issue May 4, 2021 · 4 comments
Closed

When using outside of network, Images not working #28

diamkil opened this issue May 4, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@diamkil
Copy link

diamkil commented May 4, 2021

a bit of investigation got me to the /api/file/... url which actually return the local minio url instead of the Image.. this should be fixed

@QingWei-Li
Copy link
Collaborator

You should allow external networks to access your MinIO.
Access to api/file will redirect to the file signature URL of MinIO.

@diamkil
Copy link
Author

diamkil commented May 4, 2021

I don't think it should be that way. All my databases like MySQL, InfluxDB are local only and I put MinIO the same way. If this would be fixed it would be even more awesome

@QingWei-Li
Copy link
Collaborator

QingWei-Li commented May 4, 2021

First of all, this is not a bug. Binary files such as images are usually stored on the hard disk of the server or S3. It is common practice to return the url of the file on the backend.

Secondly, if the server returns pictures, there are some disadvantages.

  1. The file will be read twice(Minio to server, server to client), halving the efficiency
  2. It will take up memory when reading files, and crash if there are too many requests at the same time

I can add an environment variable about reading files internally, if you still insist.

@diamkil
Copy link
Author

diamkil commented May 4, 2021

Would love to have the option. Your arguments are right but I personally will be using the other way

@QingWei-Li QingWei-Li added question Further information is requested enhancement New feature or request and removed question Further information is requested labels May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants