Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use status code instead of Ran too long #989

Closed
kt474 opened this issue Aug 2, 2023 · 2 comments · Fixed by #1760
Closed

Use status code instead of Ran too long #989

kt474 opened this issue Aug 2, 2023 · 2 comments · Fixed by #1760
Assignees
@kt474
Labels
enhancement New feature or request priority: high High priority issue (must have for current release)
Milestone
0.26.0

Comments

@kt474
Copy link
Member

kt474 commented Aug 2, 2023 •
edited
Loading

In a couple of places in RuntimeJob we are checking for the error reason RAN TOO LONG (example) - this is being changed on the server side so instead we should check for the error code, 1305.

Wait until ntc issue 2790 is complete
@kt474 kt474 added the enhancement New feature or request label Aug 2, 2023
@kt474 kt474 added this to the 0.11.4 milestone Aug 6, 2023
@kt474 kt474 mentioned this issue Aug 13, 2023
Closed
@jyu00 jyu00 added the priority: high High priority issue (must have for current release) label Aug 21, 2023
@kt474 kt474 modified the milestones: 0.12.0, 0.12.1 Aug 29, 2023
@kt474 kt474 self-assigned this Sep 4, 2023
@kt474 kt474 modified the milestones: 0.12.1, 0.12.2 Sep 12, 2023
@jyu00 jyu00 added the server action Need actions from the server side label Sep 18, 2023
@kt474 kt474 mentioned this issue Sep 20, 2023
Closed
@kt474 kt474 removed this from the 0.12.2 milestone Sep 28, 2023
@drew-distefano
Copy link
Collaborator

Unblocked by ntc/3494

@kt474 kt474 added the on hold label Dec 7, 2023
@kt474
Copy link
Member Author

kt474 commented Dec 18, 2023

Unblocked by ntc/3494

I think we'll have to look into this again on the server side I'm not getting any error reason code when the error is RAN TOO LONG

'state': {'status': 'Cancelled', 'reason': 'Ran too long', 'reasonCode': None}, 'status': 'Cancelled - Ran too long'

@kt474 kt474 mentioned this issue Apr 2, 2024
Merged
@jyu00 jyu00 removed on hold server action Need actions from the server side labels May 22, 2024
@kt474 kt474 added this to the 0.25.0 milestone Jun 19, 2024
@kt474 kt474 mentioned this issue Jun 19, 2024
Merged
@kt474 kt474 modified the milestones: 0.25.0, 0.26.0 Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kt474 kt474

Labels
enhancement New feature or request priority: high High priority issue (must have for current release)
Projects
None yet
Milestone
0.26.0
3 participants
@kt474 @jyu00 @drew-distefano